Disallow empty policy names on creation. #560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrodesser-Igalia
requested changes
Nov 12, 2024
| @@ -954,6 +954,7 @@ To create a {{TrustedTypePolicy}}, given a {{TrustedTypePolicyFactory}} (|factor | |||
| a string (|policyName|), {{TrustedTypePolicyOptions}} dictionary (|options|), and a | |||
| [=realm/global object=] (|global|) run these steps: | |||
|
|
|||
| 1. If |policyName| is the empty string, throw a TypeError and abort further steps. | |||
There was a problem hiding this comment.
Please link to the more general spec issue with a note like:
<p class=note> Disallowing the empty string since CSP directives can't refer to that. A limited set of other directives can't be referred to either; those, web-developers will have to rename if they need to be referenced; see https://github.com/w3c/trusted-types/issues/504#issue-2247635542.</p>
lukewarlow
approved these changes
Mar 28, 2025
| @@ -954,6 +954,7 @@ To create a {{TrustedTypePolicy}}, given a {{TrustedTypePolicyFactory}} (|factor | |||
| a string (|policyName|), {{TrustedTypePolicyOptions}} dictionary (|options|), and a | |||
| [=realm/global object=] (|global|) run these steps: | |||
|
|
|||
| 1. If |policyName| is the empty string, throw a TypeError and abort further steps. | |||
There was a problem hiding this comment.
I don't think we need to say abort further steps? Throwing automatically does that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #466.
Preview | Diff