Updates Turtle tests to use triple term syntax and reifications #135

gkellogg · 2024-03-10T21:42:25Z

… instead of quoted triples.

rdf/rdf12/rdf-turtle/eval/turtle-star-eval-annotation-6.ttl

niklasl

I think these are the required updates for the new reifier naming syntax.

rdf/rdf12/rdf-turtle/eval/turtle-star-eval-03.ttl

rdf/rdf12/rdf-turtle/eval/turtle-star-eval-04.ttl

rdf/rdf12/rdf-turtle/eval/turtle-star-eval-annotation-8.ttl

…ad of quoted triples.

…r Turtle syntax that should not be acceptable as N-Triples.

…urtle syntax.

rdf/rdf12/rdf-turtle/syntax/turtle-star-annotation-6.ttl

pchampin · 2024-08-29T16:58:45Z

This was discussed during the rdf-star meeting on 2024-08-29:
https://www.w3.org/2024/08/29-rdf-star-minutes.html#t04

pchampin · 2024-09-12T17:24:02Z

This was discussed during the rdf-star meeting on 12 September 2024.

View the transcript

w3c/rdf-tests#135

gkellogg: first one has been open for a bit. new tests for updated turtle.
… need even more on that.
… waiting for someone else to have an implementation.
… AndyS is working on updates to his parser. Hopefully we can get an approval after that.

AndyS: about at the stage where I can run those tests.

ora: so not to merge yet?

gkellogg: yeah, let's wait until someone else is passing the tests.

afs · 2024-09-15T10:55:28Z

N-triples tests:

ntriples-base* - "base" is a confusing name, especially when copied to nt-ttl-base, because they are not about BASE.
Suggestions: ntriples-langdir named after the terminal or ntriples-textdir.

ntriples-star-bad-reifier-1 tests reifier in the subject position.
ntriples-star-bad-reifier-2 tests reifier in the object position.
ntriples-star-bad-reifier-3 tests both subject and object - was a test of the predicate position intended?

ntriples-star-bad-reifier-4 is unclear. Maybe its testing declaration but it's hard to tell. Simplify to:
<< <http://example/s> <http://example/p> <http://example/o> >> .

ntriples-star-syntax-03 and ntriples-star-syntax-04 are the same.

ntriples-star-nested-bad-annotated-syntax-*.nt don't add much over ntriples-star-bnode-bad-annotated-syntax*.nt because the failure expected is at the first {|.

gkellogg · 2024-09-16T21:13:46Z

N-triples tests:

ntriples-base* - "base" is a confusing name, especially when copied to nt-ttl-base, because they are not about BASE. Suggestions: ntriples-langdir named after the terminal or ntriples-textdir.

I renamed these all as you suggested.

ntriples-star-bad-reifier-1 tests reifier in the subject position. ntriples-star-bad-reifier-2 tests reifier in the object position. ntriples-star-bad-reifier-3 tests both subject and object - was a test of the predicate position intended?

``ntriples-star-bad-reifier-4 is unclear. Maybe it's testing declaration but it's hard to tell. Simplify to: `<< http://example/s http://example/p http://example/o >> .`

I wasn't able to find these tests in the repository; there are likely some additional tests that would be required. Can you point me to them?

ntriples-star-syntax-03 and ntriples-star-syntax-04 are the same.

ntriples-star-syntax-04 was an old file, and unreferenced; I removed it.

ntriples-star-nested-bad-annotated-syntax-*.nt don't add much over ntriples-star-bnode-bad-annotated-syntax*.nt because the failure expected is at the first {|.

True, if we were to consolidate, which set should remain?

afs · 2024-09-18T19:54:27Z

I wasn't able to find these tests in the repository; there are likely some additional tests that would be required. Can you point me to them?

rdf/rdf12/rdf-n-triples/syntax/ntriples-star-bad-reifier-syntax-*.nt

ntriples-star-nested-bad-annotated-syntax-*.nt don't add much over ntriples-star-bnode-bad-annotated-syntax*.nt because the failure expected is at the first {|.

True, if we were to consolidate, which set should remain?

The simpler ntriples-star-bnode-bad-annotated-syntax*.nt. Annotations aren't in N-triples.

gkellogg · 2024-09-18T20:24:54Z

rdf/rdf12/rdf-n-triples/syntax/ntriples-star-bad-reifier-syntax-*.nt

I didn't see it because the name is slightly different: rdf/rdf12/rdf-n-triples/syntax/ntriples-star-bad-reified-syntax-*.nt. I'll take care of your suggestion.

gkellogg · 2024-09-18T20:38:30Z

This will still need updates for further grammar branches and to reconcile w3c/rdf-turtle#70.

TallTed

separators should be space-emdash-space (or space-double hyphen-space), not space-hyphen-space.

TallTed · 2024-09-18T23:48:56Z

rdf/rdf12/rdf-n-triples/syntax/index.html

          </a>
-          <span about='../syntax#ntriples-star-nested-bad-annotated-syntax-1' property='mf:name'>N-Triples-star - Bad - annotated triple, nested subject term</span>
+          <span about='../syntax#ntriples-langdir-bad-1' property='mf:name'>N-Triples literal- Bad - undefined base direction</span>


Suggested change

N-Triples literal- Bad - undefined base direction

N-Triples literal — Bad — undefined base direction

TallTed · 2024-09-18T23:49:22Z

rdf/rdf12/rdf-n-triples/syntax/index.html

@@ -482,7 +482,7 @@ <h2>
          <a class='testlink' href='#ntriples-star-bad-reified-4'>
            ntriples-star-bad-reified-4:
          </a>
-          <span about='../syntax#ntriples-star-bad-reified-4' property='mf:name'>N-Triples-star - Bad - reified triples whitespace and terms</span>
+          <span about='../syntax#ntriples-star-bad-reified-4' property='mf:name'>N-Triples-star - Bad - predicate reified triple</span>


Suggested change

N-Triples-star - Bad - predicate reified triple

N-Triples-star — Bad — predicate reified triple

TallTed · 2024-09-18T23:49:47Z

rdf/rdf12/rdf-n-triples/syntax/index.html

          </a>
-          <span about='../syntax#ntriples-star-nested-bad-annotated-syntax-2' property='mf:name'>N-Triples-star - Bad - annotated triple, nested object term</span>
+          <span about='../syntax#ntriples-langdir-bad-2' property='mf:name'>N-Triples literal- Bad - upper case LTR</span>


Suggested change

N-Triples literal- Bad - upper case LTR

N-Triples literal — Bad — upper case LTR

TallTed · 2024-09-18T23:50:14Z

rdf/rdf12/rdf-n-triples/syntax/manifest.ttl

@@ -168,7 +166,7 @@ trs:ntriples-star-bad-reified-3 rdf:type rdft:TestNTriplesNegativeSyntax ;
   .

 trs:ntriples-star-bad-reified-4 rdf:type rdft:TestNTriplesNegativeSyntax ;
-   mf:name      "N-Triples-star - Bad - reified triples whitespace and terms" ;
+   mf:name      "N-Triples-star - Bad - predicate reified triple" ;


Suggested change

mf:name "N-Triples-star - Bad - predicate reified triple" ;

mf:name "N-Triples-star — Bad — predicate reified triple" ;

This is the way the tests (all three generations) are. Developers use hyphen.
Keep it simple in the manifest because of viewing with the wrong character set.

The rest is automatically produced.

(FYI: Chicago style guide prefers no spaces around em-dashes, which then looks bad in this context.)

gkellogg added Turtle enhancement labels Mar 10, 2024

niklasl reviewed Mar 21, 2024

View reviewed changes

rdf/rdf12/rdf-turtle/eval/turtle-star-eval-annotation-6.ttl Outdated Show resolved Hide resolved

gkellogg marked this pull request as draft April 4, 2024 16:25

gkellogg marked this pull request as ready for review August 5, 2024 23:59

gkellogg requested review from niklasl and afs and removed request for niklasl August 5, 2024 23:59

niklasl suggested changes Aug 8, 2024

View reviewed changes

rdf/rdf12/rdf-turtle/eval/turtle-star-eval-03.ttl Outdated Show resolved Hide resolved

rdf/rdf12/rdf-turtle/eval/turtle-star-eval-04.ttl Outdated Show resolved Hide resolved

rdf/rdf12/rdf-turtle/eval/turtle-star-eval-annotation-8.ttl Outdated Show resolved Hide resolved

gkellogg and others added 4 commits August 15, 2024 15:03

Updates Turtle tests to use triple term syntax and reifications inste…

c38656f

…ad of quoted triples.

Automated manifest generation

28a9d1a

Update to N-Triples tests for reified triples, triple terms, and othe…

74ade4e

…r Turtle syntax that should not be acceptable as N-Triples.

Update to Turtle tests for reified triples, triple terms, and other T…

5ebe8db

…urtle syntax.

gkellogg force-pushed the turtle-reification branch from c23a7ef to 5ebe8db Compare August 15, 2024 22:03

Fix some manifest errors preventing generation of the HTML versions.

568cbec

niklasl reviewed Aug 16, 2024

View reviewed changes

rdf/rdf12/rdf-turtle/syntax/turtle-star-annotation-6.ttl Show resolved Hide resolved

gkellogg requested a review from niklasl August 17, 2024 19:20

gkellogg added 2 commits September 16, 2024 13:57

Use ntriples-langdir instead of ntriples-base.

63d38cd

Remove unreferenced ntriples-star-syntax-04.nt.

e835529

afs mentioned this pull request Sep 17, 2024

SPARQL 1.2 Functions related to initial text direction and language tags w3c/sparql-query#154

Open

gkellogg and others added 3 commits September 18, 2024 13:28

Negative N-Triples test for reifiedTriple in the predicate position.

b24c1c4

Remove ntriples-star-nested-bad-annotated-syntax-* as overlly redundant.

22acbcb

Automated manifest generation

b7ccce9

TallTed suggested changes Sep 18, 2024

View reviewed changes

afs and others added 2 commits September 19, 2024 14:35

Bad Turtle syntax for compound triples forms in reified triples

4ce8d3c

Automated manifest generation

775fce7

afs approved these changes Sep 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates Turtle tests to use triple term syntax and reifications #135

Updates Turtle tests to use triple term syntax and reifications #135

gkellogg commented Mar 10, 2024

niklasl left a comment

pchampin commented Aug 29, 2024

pchampin commented Sep 12, 2024 •

edited

Loading

w3c/rdf-tests#135

afs commented Sep 15, 2024

gkellogg commented Sep 16, 2024

afs commented Sep 18, 2024

gkellogg commented Sep 18, 2024

gkellogg commented Sep 18, 2024

TallTed left a comment

TallTed Sep 18, 2024

TallTed Sep 18, 2024

TallTed Sep 18, 2024

TallTed Sep 18, 2024

afs Sep 19, 2024

	<span about='../syntax#ntriples-langdir-bad-1' property='mf:name'>N-Triples literal- Bad - undefined base direction</span>
	<span about='../syntax#ntriples-langdir-bad-1' property='mf:name'>N-Triples literal — Bad — undefined base direction</span>

	<span about='../syntax#ntriples-star-bad-reified-4' property='mf:name'>N-Triples-star - Bad - predicate reified triple</span>
	<span about='../syntax#ntriples-star-bad-reified-4' property='mf:name'>N-Triples-star — Bad — predicate reified triple</span>

	mf:name "N-Triples-star - Bad - predicate reified triple" ;
	mf:name "N-Triples-star — Bad — predicate reified triple" ;

Updates Turtle tests to use triple term syntax and reifications #135

Are you sure you want to change the base?

Updates Turtle tests to use triple term syntax and reifications #135

Conversation

gkellogg commented Mar 10, 2024

niklasl left a comment

Choose a reason for hiding this comment

pchampin commented Aug 29, 2024

pchampin commented Sep 12, 2024 • edited Loading

w3c/rdf-tests#135

afs commented Sep 15, 2024

gkellogg commented Sep 16, 2024

afs commented Sep 18, 2024

gkellogg commented Sep 18, 2024

gkellogg commented Sep 18, 2024

TallTed left a comment

Choose a reason for hiding this comment

TallTed Sep 18, 2024

Choose a reason for hiding this comment

TallTed Sep 18, 2024

Choose a reason for hiding this comment

TallTed Sep 18, 2024

Choose a reason for hiding this comment

TallTed Sep 18, 2024

Choose a reason for hiding this comment

afs Sep 19, 2024

Choose a reason for hiding this comment

pchampin commented Sep 12, 2024 •

edited

Loading