Addition: popovertarget and command guidance #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #513 the `aria-expanded` state is implicit when using the `popovertarget` attribute - and authors are not to use the ARIA attribute with this native HTML attribute.
scottaohara
added
needs implementation commitment
adds test case for popovertarget author guidance
|
This should also be expanded to commandfor once they're in the spec. Doesn't need to be in this PR just leaving a comment so it's noted somewhere. |
the various lines of "authors may use [ attribute name ]" were unnecessary for the scope of this spec. listing out what elements the HTML attributes are used with was also unnecessary / and would require upkeep that adds extra maintenance to this spec. adds rules for command attribute, and adds aria-details allowances for popovertarget.
lukewarlow
reviewed
Apr 6, 2025
|
The table seems to have messed up a bit there's references to contenteditable and then stuff like aria-expanded? |
scottaohara
changed the title
Yeah, I’m mid edit on some of this stuff. I’ll get it fixed |
update the first column which had copied the `contenteditable` content to the correct `command` related content. update the allowances for aria-expanded to only be applicable to the toggle/show/hide popover states - since that's where the implicit conflict would come into play. other wording fixes for the attribute table cleanup that i was doing in this PR as well - for better/worse since that arguably should have been another PR... but the work is done so here it is...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #513
the
aria-expandedstate is implicit when using thepopovertargetattribute - and authors are not to use the ARIA attribute with this native HTML attribute.TODO test case
Preview | Diff