Update: account for common labeledby spelling variant for aria-labell… #2371
Conversation
…edby Updates the existing note and adds new ua and author requirements for instances of aria-labelledby and aria-labeledby
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
There was a problem hiding this comment.
Changing my review to from Approve to Nope b/c there are objections in the Issue. I don't want this to get merged in the meantime before that case is heard.
|
@rahimabdi sorry! I accidentally dismissed your review (instead of mine). |
There was a problem hiding this comment.
To update my original review. I still think the change is ok from an editorial perspective (i.e., it implements the WG's decision).
However given the renewed discussion, I'd say this something like #2422 seems like a better fit to me (instead of normative language, as the group had decided).
If the group's decision stands, then this change is ok with me.
|
@scottaohara I'm holding off on rebasing this until it's clear that this moves forward, ok? |
Updates the existing note and adds new ua and author requirements for instances of aria-labelledby and aria-labeledby
Closes #2093
i did not put this content into the accounting for author errors section, because it just fit a lot better in the aria-labelledby section. so if that's not the way we want to go about this update, then i'd appreciate help in rewording / moving the content to that section, as i was just not finding the words/logical placement for it there.
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff