Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI flatpak build #761

Merged
merged 55 commits into from
Feb 5, 2025
Merged

Fix CI flatpak build #761

merged 55 commits into from
Feb 5, 2025

Conversation

w23
Copy link
Owner

@w23 w23 commented Feb 5, 2025

flatpak CI build is failing. Figure out why and fix.

tomkidd and others added 30 commits January 26, 2025 22:25
…ault game directory uses a basedir that's base directory is undefined

That could happen when default game directory depends on base directory that don't have gameinfo.txt.
Because all game directories with liblist.gam automatically have dependency on default game directory, it causes cyclic dependency.
…cutable formats that create post link stage (was nro_install_path)
… Implement actually working rumble, ensure we're freeing up all resources related to gamepads
a1batross and others added 16 commits February 2, 2025 18:30
…Make sure all enums and structs here are not anonymous
Called on game controller becoming active or by user request.
Exposes current calibration state by read-only console variable.
…opt-in, yields better performance with VBO renderer
Use existing ui_language cvar for mounting localization folders.
…hem when Cvar_Get is called with NULL description

It allows us to not lose engine-side description when client or gameui registers cvar with the same name. In case of
menu it's the only way to get cvar pointer.
@a1batross
Copy link

It also fails due to change in GitHub that broke old artifact uploaders.

Somebody smarter than me upgraded the dependencies in flatpak-github-action, so I took that change into our local flatpak-github-action repository and tagged it.

FWGS@4832232

@a1batross
Copy link

You can merge master again. :)

…UD down to selected resolution with preserving aspect ratio
@w23
Copy link
Owner Author

w23 commented Feb 5, 2025

It also fails due to change in GitHub that broke old artifact uploaders.

Even before that there's this weird error: https://github.com/w23/xash3d-fwgs/actions/runs/13160796953/job/36728732058?pr=761#step:4:1681 as if it tries to allocate zero-sized buffer, but how does it deduce that? The count will be known at runtime only.

I'm trying to figure out how does the flatpak even work, I can't find where the build system calls waf, and how do i reproduce that build locally.

@w23 w23 marked this pull request as ready for review February 5, 2025 18:14
@w23 w23 merged commit aa890e6 into vulkan Feb 5, 2025
18 checks passed
@w23 w23 deleted the flatpak-ci-fix branch February 5, 2025 18:28
@a1batross
Copy link

Even before that there's this weird error: https://github.com/w23/xash3d-fwgs/actions/runs/13160796953/job/36728732058?pr=761#step:4:1681 as if it tries to allocate zero-sized buffer, but how does it deduce that? The count will be known at runtime only.

It's probably due to attribute alloc_size I've set on memory functions. But I specifically enabled alloc-zero as a warning, because allocating zero sized arrays generally is harmless.

But because ref_vk enforces -Werror it made compiler understandably unhappy about this. I would rather recommend disabling -Werror in ref_vk altogether because we enable a lot of diagnostics that specifically aren't treated as errors due to buggy implementation in compilers, or for something that's generally harmless (like unused variables, functions, zero-sized allocs, etc...).

I'm trying to figure out how does the flatpak even work, I can't find where the build system calls waf, and how do i reproduce that build locally.

Flatpaks are built from recipes, the recipe file for our flatpak is in scripts/flatpak/su.xash.engine.Compat.i386.yml. It says which SDK version to use and how to build the app. That recipes are processed by flatpak-builder utility.

@w23
Copy link
Owner Author

w23 commented Feb 5, 2025

I would rather recommend disabling -Werror in ref_vk altogether ...

No! I like it rough, when compiler is rude to me, and hurts me and violates my expectations!11

Flatpaks are built from recipes, the recipe file for our flatpak is in scripts/flatpak/su.xash.engine.Compat.i386.yml. It says which SDK version to use and how to build the app. That recipes are processed by flatpak-builder utility.

Yeah, already figured that one out.

@a1batross
Copy link

No! I like it rough, when compiler is rude to me, and hurts me and violates my expectations!11

Then don't be a pussy and use clang with -Werror=everything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants