[E387] Merge from upstream #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some configuration, like Flatpak, on dev machines or when packaging for *nix we can safely link with system libraries.
Link to GitHub issue: xiph/opus#374
…ctions that's engine core or server are dependent on
… directories to the include path. Also, set cmake minimum required version to 3.5 only to shut up deprecation notice.
…hat cmake.py has subst support
…generated files This helps avoid issue when the bzip2 or libogg are compiled before header is generated for them. In theory, we shouldn't do that, but I guess dependency calculation through include directives doesn't work when the file doesn't exist.
… as Android doesn't have any
…lower than 24 In API level 21 **and** _FILE_OFFSET_BITS == 64 we don't get fseeko/ftello functions. To avoid increasing API level, just set _FILE_OFFSET_BITS to some bogus value. Undefining it doesn't work as opusfile sets it to 64 automatically.
…k them in dedicated
…ather than on server dll unload
…'t exist in client.dll
…ls platform-specific delay functions
…ific implementations of Platform_Sleep to make them inlined
Try to fix CI.
Also improved uplink setup and used a better source for mod files.
|
лол CI среньк, потому что vulkan.lunarg.com лёг полежать |
See stream E388 in its entirety for discussion. TLDR: the engine won't call `R_EndFrame()` if there was nothing to draw, as this prevents rendering artifacts on some devices. ref_vk wasn't ready for any of that.
Make `R_TextureUploadFromBuffer` properly track reference counts under ref-api semantics. Started appearing by the merge, probably the engine started using this function slightly differently. Missing textures were sometimes triggered by the presence of the texture in PBR patches. See stream E389.
|
Fixing missing textures also fixed a bunch of violet garbage and missing lights it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref_interface_tfuncsplaydemoassert fail inR_BeginFrame()? waiting for upstream fix (see E388, first 45min)-- workaround is finemap c0a0bthenmap c0a0cR_BeginFrame(w/ debugger)