Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6834 static_route module to support interface_route #398

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

omnom62
Copy link
Contributor

@omnom62 omnom62 commented Feb 21, 2025

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6834

Related PR(s)

Component(s) name

static_routes

Proposed changes

How to test

Test results

$ ansible-tests units
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-8.3.3, pluggy-1.5.0 -- /usr/bin/python3.12
rootdir: /root/ansible_collections/vyos/vyos
configfile: ../../../ansible/test/lib/ansible_test/_data/pytest/config/default.ini
plugins: xdist-3.6.1, mock-3.14.0
created: 8/8 workers
8 workers [343 items]

scheduling tests via LoadScheduling
....
[gw7] [ 99%] PASSED tests/unit/modules/network/vyos/test_vyos_user.py::TestVyosUserModule::test_vyos_user_update_password_changed
[gw3] [100%] PASSED tests/unit/modules/network/vyos/test_vyos_user.py::TestVyosUserModule::test_vyos_user_update_password_always

  • generated xml file: /root/ansible_collections/vyos/vyos/tests/output/junit/python3.12-controller-units.xml -
    ============================= 343 passed in 9.11s ==============================

  • Sanity tests passed

  • Unit tests passed

Tested against VyOS versions:

  • 1.3.8
  • 1.4-rolling-202201010100
  • vyos-1.5-rolling-202502120007

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the ansible sanity and unit tests
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added unit tests to cover my changes
  • I have added a file to changelogs/fragments to describe the changes

@omnom62 omnom62 marked this pull request as ready for review February 25, 2025 19:48
@omnom62 omnom62 requested a review from a team as a code owner February 25, 2025 19:48
@omnom62 omnom62 requested review from zdc, gaige and vyosbot February 25, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant