Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: fix inaccurate test timer in benchmark #286

Merged
merged 1 commit into from
Nov 11, 2024
Merged

workflow: fix inaccurate test timer in benchmark #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/client/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ const swapRows = wrap('swap', () => {
async function bench() {
for (let i = 0; i < 30; i++) {
rows.value = []
await defer()
await runLots()
await defer()
}
}

Expand Down
6 changes: 4 additions & 2 deletions benchmark/client/profiling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
/* eslint-disable no-restricted-syntax */
/* eslint-disable no-restricted-globals */

import { nextTick } from '@vue/vapor'

declare namespace globalThis {
let doProfile: boolean
let reactivity: boolean
Expand Down Expand Up @@ -29,13 +31,13 @@ export function wrap(
document.body.classList.remove('done')

const { doProfile } = globalThis
await defer()
await nextTick()

doProfile && console.profile(id)
const start = performance.now()
fn(...args)

await defer()
await nextTick()
let time: number
if (globalThis.reactivity) {
time = performance.measure(
Expand Down