Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onBeforeRouteLeave not remove (fix #3826) #3875

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

wynn719
Copy link

@wynn719 wynn719 commented Nov 16, 2023

The problem seems to be that onBeforeRouteLeave lacks handling of onActivated and onDeactivated hooks in the keep-alive component.

I referred to vue router 4 to fix the processing of onBeforeRouteLeave.

https://github.com/vuejs/router/blob/main/packages/router/src/navigationGuards.ts

Fix #3826

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for vue-router-docs-v3 canceled.

Name Link
🔨 Latest commit b382a4f
🔍 Latest deploy log https://app.netlify.com/sites/vue-router-docs-v3/deploys/65577936393c7f0008385ce8

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/composables/guards.js Outdated Show resolved Hide resolved
src/composables/guards.js Outdated Show resolved Hide resolved
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/composables/guards.js Outdated Show resolved Hide resolved
src/composables/guards.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants