fix: combining 'end' and 'strict' #2154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Playground illustrates the problem:
The bottom row is the one that isn't working correctly. This combination of options:
should match the location path
/user/1
, but it doesn't.The reason why is the RegExp is checking for the
/
twice:While I've added a lot of extra testing for
end: false
, only two of those assertions would have failed with the previous code. Specifically, this one on line 666:and this one on line 673:
In both cases they would previously have failed to resolve the route.