Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement show only preview feature using toggle button #291

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mg5566
Copy link

@mg5566 mg5566 commented Oct 20, 2024

스크린샷 2024-10-20 오후 3 52 33

I implement a show only preview toggle button

On small screens, the toggle button below disappears.
On larger screens, it should look like the video below.
스크린샷 2024-10-20 오후 3 53 13

2024-10-20.3.56.14.mov

close #290

Copy link

vercel bot commented Oct 20, 2024

@mg5566 is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

@mg5566
Copy link
Author

mg5566 commented Oct 20, 2024

Feedback

I'm not sure what to do with the provider / inject key name.
I'm not sure if the button text 'show preview' is correct from the user's point of view.
Please let us know what you think and we'll take it into account.

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we change showPreview for controlling? Maybe should put showPreview to props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Option to display only the preview without editor
2 participants