Docs: Migrate mockedStore typings to vitest v2 #2759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate the typings of `mockedStore` to the changes of >[email protected]: see: https://vitest.dev/guide/migration#simplified-generic-types-of-mock-functions-e-g-vi-fn-t-mock-t https://github.com/vitest-dev/vitest/releases/tag/v2.0.0
✅ Deploy Preview for pinia-playground canceled.
|
✅ Deploy Preview for pinia-official ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lud-hu
changed the title
posva
requested changes
Sep 2, 2024
| @@ -191,7 +191,7 @@ function mockedStore<TStoreDef extends () => unknown>( | |||
| ...args: infer Args | |||
| ) => infer ReturnT | |||
| ? // 👇 depends on your testing framework | |||
| Mock<Args, ReturnT> | |||
| Mock<(args: Args) => ReturnT> | |||
There was a problem hiding this comment.
Although now it should be able to just take Actions[K]. I need to test it
netroy
reviewed
Sep 12, 2024
| @@ -191,7 +191,7 @@ function mockedStore<TStoreDef extends () => unknown>( | |||
| ...args: infer Args | |||
| ) => infer ReturnT | |||
| ? // 👇 depends on your testing framework | |||
| Mock<Args, ReturnT> | |||
| Mock<(args: Args) => ReturnT> | |||
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| Mock<(args: Args) => ReturnT> | |
| Mock<(...args: Args) => ReturnT> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs to migrate the typings of
mockedStoreto the changes of >[email protected]:see:
https://vitest.dev/guide/migration#simplified-generic-types-of-mock-functions-e-g-vi-fn-t-mock-t
https://github.com/vitest-dev/vitest/releases/tag/v2.0.0