-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Register stores dir in all layers #2757
base: v2
Are you sure you want to change the base?
Auto Register stores dir in all layers #2757
Conversation
✅ Deploy Preview for pinia-playground canceled.
|
✅ Deploy Preview for pinia-official ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
will this still register the stores dirs defined in layers if the main app defines it's own storesDirs? It seems like that null check would make it only apply the layers stores when the parent app sets it to null. |
No because The |
This looks very good; thanks for writing the patch. I was just hitting this layer issue. Why change the falsey check into a null check? If you want to keep it so, perhaps use
|
I made this wrapper module to work around this issue: https://gist.github.com/tommie/1e505f3f7a281698bdb9fdc7a303e6c0 |
Thank you
|
Currently if user did not specify custom storesDir then the expected to auto import stores from stores dir but this is not working inside layers