Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn developers for duplicated store keys #1731

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

rmartins90
Copy link

@rmartins90 rmartins90 commented Oct 18, 2022

Another attempt to contribute to #1394 🙂

In tests, I'm getting various warnings because those tests are using duplicated names for stores. I'm not sure how to approach this in a smart way, appreciate any help or feedback.

Tried this approach to avoid messing with ._s registry property. What are your thoughts?

Closes #1394

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit fbfc830
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/634eb394815f980008b90d4c

@posva posva changed the title chore: warn developers for duplicated store keys feat: warn developers for duplicated store keys Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Warn if two stores are defined with the same name
2 participants