Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: playwright component testing #249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: playwright component testing #249

wants to merge 1 commit into from

Conversation

sand4rt
Copy link

@sand4rt sand4rt commented Apr 7, 2023

No description provided.

@haoqunjiang
Copy link
Member

Thanks for the PR!
But IMO, if we are to tell the users that component testing is also supported, we need to add a template for it first, otherwise users might be confused when they see no reference to the component testing after scaffolding the project.

@sand4rt
Copy link
Author

sand4rt commented May 4, 2023 •
edited
Loading

Yeah agree. Would you like me to add the template?

The same text is in place for Cypress BTW.

@haoqunjiang
Copy link
Member

haoqunjiang commented May 4, 2023 •
edited
Loading

Yeah, go ahead, please.
Cypress Component Testing templates have been added long ago so that text is in place.

@sand4rt
Copy link
Author

sand4rt commented May 4, 2023

Cool, will give it a try!

@sand4rt sand4rt force-pushed the playwright-ct-description branch 2 times, most recently from 0198f12 to b98a4b9 Compare May 18, 2023 16:49
@sand4rt sand4rt changed the title chore: playwright component testing description feat: playwright component testing May 18, 2023
@sand4rt sand4rt force-pushed the playwright-ct-description branch 6 times, most recently from 0d60b4e to 46c4818 Compare May 18, 2023 18:06
@sand4rt sand4rt force-pushed the playwright-ct-description branch from 46c4818 to 7182b40 Compare May 18, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sand4rt @haoqunjiang