Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to webpack-dev-server #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qkdreyer
Copy link

@qkdreyer
Copy link
Author

@LinusBorg Could you review this PR please ? :)

Copy link
Collaborator

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is unrelated to the service worker-controlled experience, since there's no service worker generated in the dev environment, and I don't see anything that's changed in the npm run build output.

Therefore, I'm happy to get this implemented to match what's being done upstream in the webpack template.

I'll give @LinusBorg a little more time to comment in case there were more plans for changes upstream, but otherwise, this should be good.

@jmbejar
Copy link

jmbejar commented Jan 14, 2018

Any news about this PR? It's been a while since vuejs-templates/webpack#975 was merged. It's great to have this pwa template in sync with progress made in the base template (webpack).

@LinusBorg
Copy link
Contributor

Hey totally forgot about this, sorry. There were some hickups we had after we merged the initial PR (vuejs-templates/webpack#975), I'll share those wit you tomorrow when I find a minute to write it down properly.

As all of those additional changes were about the webpack config, you can also see them when looking at the current version of webpack.dev.conf.js over at our repository.

@jaromero
Copy link

Hello!

What is the status of this PR? I found myself having to turn HTTPS on for development in my app (Facebook login now requires it) and this looks like what I need to enable it, but @LinusBorg's comment makes me think that there are issues with this still.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants