Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subgroups + custom group tags #670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnsusek
Copy link

@johnsusek johnsusek commented Apr 18, 2020

  • What kind of change does this PR introduce?
    • A feature to add a subgroup within a group
    • A feature to specify group tag per group
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No, feature addition only.

I've also added subgroups to the dev group example:

Screen Shot 2020-04-18 at 2 16 29 PM


Since these changes allow custom tags and subgroups, complex behavior like putting subgroups into tabs is possible. Here's what it looks like with bootstrap-vue tabs for subgroups:

Screen Shot 2020-04-18 at 2 17 12 PM


Please let me know if there's anything you would like done differently! I hope we can get this subgrouping behavior in, we are using vfg in a project with very complex forms and could really use something like this.

Related issue: #285

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.979% when pulling 9bbb143 on johnsusek:feature/subgroups into 721a4ee on vue-generators:master.

@DelfsEngineering
Copy link

DelfsEngineering commented Apr 18, 2020

This is interesting but I think a visible key really needs to be part of this to make it really useful. I think a visible tag in on another PR.
I don't see a sample of what the schema would look like, I am assuming it can go multiple levels deep?

@johnsusek
Copy link
Author

johnsusek commented Apr 18, 2020

For our use case, this functionality is definitely useful and would go into use right away to group forms into subsections. And other people would like it too imho, as evidence I would point to #285.

But maybe I don't understand - can you elaborate on this "visible" feature and why it is important for this PR?

Thanks for the feedback!

@DelfsEngineering
Copy link

A visible key at the group level to hide the entire group, currently it must be done via css.

@johnsusek
Copy link
Author

That sounds like it would be a useful addition to vfg. If that feature is added to the codebase I would be happy to help integrate it with this subgroups feature.

@DelfsEngineering
Copy link

Basically it would allow you to have a login, password reset and sign up groups all in one form.

@DelfsEngineering
Copy link

@johnsusek Would this support recursive groups also? or just one level down?

@Mohammad-Alavi
Copy link

This is a nice feature. Why it is not merged yet? 🤔

@vortechron
Copy link

@icebob merge it please :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants