Add Ubuntu 24.04 support

.github/workflows/ci.yml

@@ -75,6 +75,8 @@ jobs:
             value: ubuntu2004-64vpnserver.ma{hostname=vpnserver}-ubuntu2004-64vpnclienta.a{hostname=vpnclienta}
           - name: Ubuntu 22.04
             value: ubuntu2204-64vpnserver.ma{hostname=vpnserver}-ubuntu2204-64vpnclienta.a{hostname=vpnclienta}
+          - name: Ubuntu 24.04
+            value: ubuntu2404-64vpnserver.ma{hostname=vpnserver}-ubuntu2404-64vpnclienta.a{hostname=vpnclienta}
         puppet: ${{fromJson(needs.setup_matrix.outputs.puppet_major_versions)}}
     name: ${{ matrix.puppet.name }} - ${{ matrix.setfile.name }}
     steps:

data/family/Debian/24.04.yaml

@@ -0,0 +1,2 @@
+---
+openvpn::default_easyrsa_ver: '3.0'

lib/facter/easyrsa.rb

@@ -14,7 +14,7 @@
       binaryv3 = '/usr/share/easy-rsa/3/easyrsa'
     when %r{Ubuntu|Debian}
       case operatingsystemrelease
-      when %r{9|10|11|18.04|20.04|22.04}
+      when %r{9|10|11|18.04|20.04|22.04|24.04}
         binaryv2 = '/usr/share/easy-rsa/pkitool'
         binaryv3 = '/usr/share/easy-rsa/easyrsa'
       else

metadata.json

@@ -13,7 +13,8 @@
       "operatingsystem": "Ubuntu",
       "operatingsystemrelease": [
         "20.04",
-        "22.04"
+        "22.04",
+        "24.04"
       ]
     },
     {

spec/acceptance/openvpn_spec.rb

@@ -23,7 +23,7 @@
   server_directory = '/etc/openvpn'
   client_directory = '/etc/openvpn'
   client_service = 'openvpn'
-  if fact('os.release.major') =~ %r{10|11|20.04|22.04}
+  if fact('os.release.major') =~ %r{10|11|20.04|22.04|24.04}
     server_crt = "#{server_directory}/test_openvpn_server/easy-rsa/keys/issued/server.crt"
     key_path = "#{server_directory}/test_openvpn_server/easy-rsa/keys/private"
     crt_path = "#{server_directory}/test_openvpn_server/easy-rsa/keys/issued"
@@ -45,7 +45,7 @@
 # Default value is with ciphers too recent for old OSes like ubuntu 14.04.
 describe 'server defined type' do
   context 'with basics parameters' do
     it 'installs openvpn server idempotently' do
       pp = %(
         openvpn::server { 'test_openvpn_server':
           country      => 'CO',
@@ -63,7 +63,7 @@
       apply_manifest_on(hosts_as('vpnserver'), pp, catch_changes: true)
     end
 
     it 'creates openvpn client certificate idempotently' do
       pp = %(
         openvpn::server { 'test_openvpn_server':
           country      => 'CO',
@@ -88,7 +88,7 @@
       apply_manifest_on(hosts_as('vpnserver'), pp, catch_changes: true)
     end
 
     it 'revokes openvpn client certificate' do
       pp = %(
         openvpn::server { 'test_openvpn_server':
           country      => 'CO',
@@ -118,7 +118,7 @@
     end
 
     describe file("#{server_directory}/test_openvpn_server/easy-rsa/revoked/vpnclientb"), :revokedFile do
       it { is_expected.to be_file }
     end
 
     describe file("#{server_directory}/test_openvpn_server/easy-rsa/keys") do
@@ -136,20 +136,20 @@
     end
 
     describe file(server_crt.to_s), :crtFile do
       it { is_expected.to be_file }
       it { is_expected.to contain 'Issuer: C=CO, ST=ST, L=A city, O=FOO, ' }
     end
 
     describe process('openvpn') do
       it { is_expected.to be_running }
     end
 
     describe port(1194) do
       it { is_expected.to be_listening.with('tcp') }
     end
 
     describe command('ip link show tun0') do
       its(:stdout) { is_expected.to match %r{.* tun0: .*} }
       its(:exit_status) { is_expected.to eq 0 }
     end
 
@@ -172,7 +172,7 @@
       its(:size) { is_expected.to be > 500 }
     end
 
     it 'permits to setup a vpn client' do
       scp_from(hosts_as('vpnserver'), "#{server_directory}/test_openvpn_server/download-configs/vpnclienta.tar.gz", '.')
       scp_to(hosts_as('vpnclienta'), 'vpnclienta.tar.gz', '/tmp')
       on(hosts_as('vpnclienta'), "tar xvfz /tmp/vpnclienta.tar.gz -C #{client_directory}")

spec/defines/openvpn_ca_spec.rb

@@ -116,7 +116,7 @@
 
           # Execs to working with certificates
 
-          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04}
+          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04|24.04}
             it { is_expected.to contain_exec('generate dh param test_server').with_creates("#{server_directory}/test_server/easy-rsa/keys/dh.pem") }
           else
             it { is_expected.to contain_exec('generate dh param test_server').with_creates("#{server_directory}/test_server/easy-rsa/keys/dh2048.pem") }
@@ -126,7 +126,7 @@
           it { is_expected.to contain_exec('create crl.pem on test_server') }
           it { is_expected.not_to contain_exec('update crl.pem on test_server') }
 
-          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04}
+          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04|24.04}
             it { is_expected.to contain_file("#{server_directory}/test_server/easy-rsa/vars").with_content(%r{^export EASYRSA_CA_EXPIRE=3650$}) }
             it { is_expected.to contain_file("#{server_directory}/test_server/easy-rsa/vars").with_content(%r{^export EASYRSA_CERT_EXPIRE=3650$}) }
             it { is_expected.not_to contain_file("#{server_directory}/test_server/easy-rsa/vars").with_content(%r{^export EASYRSA_REQ_CN"$}) }
@@ -161,7 +161,7 @@
             }
           end
 
-          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04}
+          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04|24.04}
             it { is_expected.to contain_file("#{server_directory}/test_server/easy-rsa/vars").with_content(%r{^export EASYRSA_DN="cn_only"$}) }
             it { is_expected.to contain_file("#{server_directory}/test_server/easy-rsa/vars").with_content(%r{^export EASYRSA_CA_EXPIRE=365$}) }
             it { is_expected.to contain_file("#{server_directory}/test_server/easy-rsa/vars").with_content(%r{^export EASYRSA_CERT_EXPIRE=365$}) }
@@ -176,7 +176,7 @@
             it { is_expected.to contain_file("#{server_directory}/test_server/easy-rsa/vars").with_content(%r{^export KEY_OU="NSA"$}) }
           end
 
-          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04}
+          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04|24.04}
             it { is_expected.to contain_exec('generate dh param test_server').with_creates("#{server_directory}/test_server/easy-rsa/keys/dh.pem") }
           else
             it { is_expected.to contain_exec('generate dh param test_server').with_creates("#{server_directory}/test_server/easy-rsa/keys/dh2048.pem") }
@@ -194,7 +194,7 @@
             }
           end
 
-          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04}
+          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04|24.04}
             it {
               is_expected.to contain_file("#{server_directory}/test_server/easy-rsa/openssl.cnf").with(
                 'ensure' => 'link',

spec/defines/openvpn_client_spec.rb

@@ -41,7 +41,7 @@
 
       case facts[:os]['family']
       when 'Ubuntu', 'Debian'
-        if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04}
+        if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04|24.04}
           context 'system with easyrsa3' do
             it {
               is_expected.to contain_file("#{server_directory}/test_server/download-configs/test_client/keys/test_client/test_client.crt").with(
@@ -265,7 +265,7 @@
 
         case facts[:os]['family']
         when 'Ubuntu', 'Debian'
-          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04}
+          if facts[:os]['release']['major'] =~ %r{10|11|20.04|22.04|24.04}
             context 'system with easyrsa3' do
               it {
                 is_expected.to contain_file("#{server_directory}/test_server/download-configs/test_client/keys/test_client/test_client.crt").with(