Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements-check: Review Knative #83

Open
johnSchnake opened this issue Dec 22, 2021 · 1 comment
Open

requirements-check: Review Knative #83

johnSchnake opened this issue Dec 22, 2021 · 1 comment

Comments

@johnSchnake
Copy link
Contributor

Review https://knative.dev/docs/install/serving/install-serving-with-yaml/ and related pages to see what can be automated and what gaps remain.

@johnSchnake
Copy link
Contributor Author

Super important check that isnt often stated must have access to the internet.

Even that is somewhat optional because you can pull from a private repo if configured.

Also had conditional checks (IF one node check XYZ otherwise ABC). So we either just rely on a library of checks and make users spell it out or we allow for abstractions like OR and AND which can be composited.

In the yaml file I imagine that would look something like a prefix notation for math operators:

AND:
   check1...
   check2...
OR:
   checkA...
   checkB...
   checkC...

The only problem is that even though you can imagine the types being somewhat simple:

type AndCheck struct{
 []Check
}

It wouldn't be as simple to serialize/deserialize those checks because they could be of any type of check. It would then effectively be like we just handling arbitrary yaml which will be more complex. Not sure if there are other limitations or if it is just more complex to execute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant