Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cache Hinting for fused_moe kernel #15511

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Conversation

wrmedford
Copy link
Contributor

@wrmedford wrmedford commented Mar 26, 2025

Forward compatible change with triton-lang/triton#6278. Benchmark below is for when it's merged.

Before

============ Serving Benchmark Result ============
Successful requests:                     500
Benchmark duration (s):                  116.83
Total input tokens:                      50000
Total generated tokens:                  500000
Request throughput (req/s):              4.28
Output token throughput (tok/s):         4279.83
Total Token throughput (tok/s):          4707.81
---------------Time to First Token----------------
Mean TTFT (ms):                          161.36
Median TTFT (ms):                        133.79
P99 TTFT (ms):                           1117.93
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          72.26
Median TPOT (ms):                        72.86
P99 TPOT (ms):                           75.91
---------------Inter-token Latency----------------
Mean ITL (ms):                           72.19
Median ITL (ms):                         72.33
P99 ITL (ms):                            116.49
==================================================

After

============ Serving Benchmark Result ============
Successful requests:                     500
Benchmark duration (s):                  116.62
Total input tokens:                      50000
Total generated tokens:                  500000
Request throughput (req/s):              4.29
Output token throughput (tok/s):         4287.33
Total Token throughput (tok/s):          4716.07
---------------Time to First Token----------------
Mean TTFT (ms):                          141.31
Median TTFT (ms):                        131.75
P99 TTFT (ms):                           469.73
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          71.41
Median TPOT (ms):                        72.11
P99 TPOT (ms):                           74.47
---------------Inter-token Latency----------------
Mean ITL (ms):                           71.34
Median ITL (ms):                         71.13
P99 ITL (ms):                            111.78
==================================================

Slight improvement, mostly in latency metrics.

Interface already exists, so this is safe to merge now.

Big thanks to @Apsu on all of the help here!

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@youkaichao
Copy link
Member

@LucasWilkinson @bnellnm can you help review?

@LucasWilkinson
Copy link
Collaborator

Seems straight forward enough, this shouldn't cause any issue on non-Nvidia hardware? i.e. these parameters are just ignored right?

Copy link
Contributor

@bnellnm bnellnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming:

this shouldn't cause any issue on non-Nvidia hardware? i.e. these parameters are just ignored right?

@wrmedford
Copy link
Contributor Author

Seems straight forward enough, this shouldn't cause any issue on non-Nvidia hardware? i.e. these parameters are just ignored right?

Afaik these bindings have existed in triton for a while and it's up to the backend to implement them. Otherwise they're ignored.

@LucasWilkinson LucasWilkinson enabled auto-merge (squash) March 26, 2025 19:58
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 26, 2025
@LucasWilkinson LucasWilkinson merged commit 7a88827 into vllm-project:main Mar 26, 2025
41 of 42 checks passed
@DefTruth
Copy link
Contributor

The latest stable version of triton dont contains: triton-lang/triton#6278

DefTruth added a commit to vipshop/vllm that referenced this pull request Mar 27, 2025
wrmedford added a commit to wrmedford/vllm that referenced this pull request Mar 27, 2025
wrmedford added a commit to wrmedford/vllm that referenced this pull request Mar 27, 2025
vllm-bot pushed a commit that referenced this pull request Mar 28, 2025
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 2, 2025
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 2, 2025
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants