-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Cache Hinting for fused_moe kernel #15511
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
@LucasWilkinson @bnellnm can you help review? |
Seems straight forward enough, this shouldn't cause any issue on non-Nvidia hardware? i.e. these parameters are just ignored right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming:
this shouldn't cause any issue on non-Nvidia hardware? i.e. these parameters are just ignored right?
Afaik these bindings have existed in triton for a while and it's up to the backend to implement them. Otherwise they're ignored. |
The latest stable version of triton dont contains: triton-lang/triton#6278 |
This reverts commit 7a88827.
This reverts commit 7a88827.
This reverts commit 7a88827. Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
…llm-project#15645) Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
…llm-project#15645) Signed-off-by: Wes Medford <[email protected]> Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
…llm-project#15645) Signed-off-by: Wes Medford <[email protected]> Signed-off-by: xinyuxiao <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
…llm-project#15645) Signed-off-by: Wes Medford <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Forward compatible change with triton-lang/triton#6278. Benchmark below is for when it's merged.
Before
After
Slight improvement, mostly in latency metrics.
Interface already exists, so this is safe to merge now.
Big thanks to @Apsu on all of the help here!