Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Draft] Jump-forward decoding #15490

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Mar 25, 2025

This PR aims to add support for jump-forward decoding by introducing the following API:

  • For Grammar class:
    • jump_forward_string: returns the longest jf-able string from the FSM
    • find_token_divergence: returns the index of shared outputs ids between (prev_output) and (prev_output+jf_string) and handle FSM accordingly

--wip--

Signed-off-by: Aaron Pham [email protected]

and update interface for jf decoding

Signed-off-by: Aaron Pham <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@aarnphm
Copy link
Collaborator Author

aarnphm commented Mar 26, 2025

Will ping once it is ready, discussing with Yixin atm to clear up some confusion

@mergify mergify bot added tpu Related to Google TPUs and removed tpu Related to Google TPUs labels Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants