Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-node offline DP+EP example #15484

Merged
merged 4 commits into from
Mar 26, 2025
Merged

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Mar 25, 2025

to make it easy to run multi-node DP+EP.

I have verified that the following command works:

# node 0
python examples/offline_inference/data_parallel.py --node-size 2 --node-rank 0 --master-addr 10.99.48.128 --master-port 13345
# node 1
python examples/offline_inference/data_parallel.py --node-size 2 --node-rank 1 --master-addr 10.99.48.128 --master-port 13345

Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
@youkaichao youkaichao requested a review from tlrmchlsmth March 25, 2025 16:42
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 25, 2025
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the usage line at the start of the file to show how to use it in the multinode case

Signed-off-by: youkaichao <[email protected]>
@youkaichao
Copy link
Member Author

Could you update the usage line at the start of the file to show how to use it in the multinode case

fixed in 9a196ae

@youkaichao youkaichao merged commit e64afa4 into vllm-project:main Mar 26, 2025
10 of 12 checks passed
@youkaichao youkaichao deleted the dp_offline branch March 26, 2025 15:54
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 2, 2025
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants