Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention extra_body as a way top pass vLLM only parameters using the OpenAI client #15240

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Mar 20, 2025

Closes #2733

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 20, 2025
Signed-off-by: Harry Mellor <[email protected]>
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for updating!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 20, 2025
@vllm-bot vllm-bot merged commit 6edbfa9 into vllm-project:main Mar 21, 2025
20 of 22 checks passed
@hmellor hmellor deleted the doc-extra-body branch March 21, 2025 11:46
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better defaults to match Hugging Face
3 participants