Skip to content

Use HFCompatibleLoRA instead of instance method replacement #14131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Mar 3, 2025

Follow up for suggestion mentioned in #13770 (comment)

Changes:

  • Reverts changes made to layers.py
  • Uses __class__ so that HFCompatibleLinear appears as vLLM layer (use __wrapper_class__ as a way to identify the true class)
  • Add HFCompatibleLoRA which uses the same technique
  • Replace use of deprecated Python 3.8 types in changed files

This means that when printing models or examining layers, type(layer) will return the inner layer, rather than HFCompatibleX. This stops the layer replacement from hiding the type of the original layer.

@hmellor hmellor requested a review from Isotr0py March 3, 2025 10:20
Copy link

github-actions bot commented Mar 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

hmellor added 5 commits March 3, 2025 11:22
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 3, 2025
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup effort!

@hmellor
Copy link
Member Author

hmellor commented Mar 3, 2025

After some more tinkering, it appears that __class__ cannot be used as I am attempting to use it in this PR. I'll close this and perhaps try an alternative method another time.

@hmellor hmellor closed this Mar 3, 2025
@hmellor hmellor deleted the refactor-transformers-lora branch March 10, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants