Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vLLM beijing meetup notes #42

Closed
wants to merge 5 commits into from

Conversation

shen-shanshan
Copy link

Add vLLM beijing meetup notes.

cc @youkaichao @simon-mo @Yikun @wangxiyuan

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice!

My only comments would be:

  • Are you able to link to any slides/recordings so that readers can learn more about particular talks?
  • It seems a little confusing to start with ### Summary. What do you think about:
    • removing ### Summary
    • adding ## Talks immediately before ### vLLM Update

@shen-shanshan
Copy link
Author

This looks nice!

My only comments would be:

  • Are you able to link to any slides/recordings so that readers can learn more about particular talks?

  • It seems a little confusing to start with ### Summary. What do you think about:

    • removing ### Summary
    • adding ## Talks immediately before ### vLLM Update

OK, I will adjust it.

@shen-shanshan shen-shanshan marked this pull request as draft March 17, 2025 14:30
@shen-shanshan shen-shanshan reopened this Mar 17, 2025
Signed-off-by: 申杉杉 <[email protected]>
shen-shanshan and others added 4 commits March 17, 2025 23:18
Signed-off-by: 申杉杉 <[email protected]>
Signed-off-by: 申杉杉 <[email protected]>
Signed-off-by: 申杉杉 <[email protected]>
Signed-off-by: Shanshan Shen <[email protected]>
@shen-shanshan shen-shanshan marked this pull request as ready for review March 19, 2025 09:49
@Yikun
Copy link

Yikun commented Mar 19, 2025

We had a offline discuss with @youkaichao.

According history, we didn't publish the meetup notes, so we just publish it in local channel:

https://mp.weixin.qq.com/s/VtxO9WXa5fC-mKqlxNUJUQ

So pls @shen-shanshan close this PR, thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants