[core] Support custom ascendc kernels in vllm-ascend #233
+1,378
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganyi1996ppo
changed the title
wangxiyuan
reviewed
Mar 4, 2025
setup.py
Outdated
| # First, run the standard build_ext command to compile the extensions | ||
| super().run() | ||
|
|
||
| # copy vllm/vllm_flash_attn/*.py from self.build_lib to current |
There was a problem hiding this comment.
do not comment useless code.
There was a problem hiding this comment.
sure, I'll remove some of the unused code later.
ganyi1996ppo
force-pushed
the
ganyi/cus_ops
branch
from
c8bfa85 to
9f0dc37
Compare
wangxiyuan
referenced
this pull request
Mar 18, 2025
Add multi step scheduler support for vllm-ascend Signed-off-by: new-TonyWang <[email protected]>
ganyi1996ppo
changed the title
ganyi1996ppo
force-pushed
the
ganyi/cus_ops
branch
3 times, most recently
from
1fb60ef to
8ae9108
Compare
ganyi1996ppo
force-pushed
the
ganyi/cus_ops
branch
from
e811591 to
a52dd05
Compare
Add custom ascendc kernel support in vllm-ascend, this PR mainly include 3 parts: - AscendC implementation of rotary_embedding, and its unitest. - CMakeLists.txt to compile AscendC kernel and related torch library binding to this kernel. - Build and pack all the compiled so into the vllm_ascend's package. For now, this rotary embedding kernel dose not support the scenario with `neoxStyle=False`, So its not used in the actual modeling parts. We will soon add this implements into the vllm-ascend and integrate it into the modeling parts. No change at all --------- Signed-off-by: ganyi <[email protected]>
Signed-off-by: ganyi <[email protected]>
…build Signed-off-by: ganyi <[email protected]>
Signed-off-by: ganyi <[email protected]>
Signed-off-by: ganyi <[email protected]>
Signed-off-by: ganyi <[email protected]>
Signed-off-by: ganyi <[email protected]>
ganyi1996ppo
force-pushed
the
ganyi/cus_ops
branch
from
3cc0e28 to
29b4aa0
Compare
Signed-off-by: ganyi <[email protected]>
wuhuikx
reviewed
Apr 2, 2025
| reinterpret_cast<TYPE *>(cosSinCache), rotDim, queryStride, keyStride, dstQueryStride, dstKeyStride, \ | ||
| numHeads, numKvHeads, headSize, numTokens, loopCnt, blockDim); | ||
|
|
||
| static const int64_t maxParallelSize = 65535; |
There was a problem hiding this comment.
Can we add some comments here for the magic number? Or can we get the parallelsize from runtime API? why 65535 here?
Signed-off-by: ganyi <[email protected]>
Signed-off-by: ganyi <[email protected]>
Signed-off-by: ganyi <[email protected]>
wangxiyuan
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add custom ascendc kernel rotary_embedding support in vllm-ascend, related CMakeLists and setuptools is also added in this PR.
Related: #156