Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] add support for creating ServiceMonitor in Helm chart #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hexoplon
Copy link
Contributor

Add support for creating a ServiceMonitor directly in the helm chart. This simplifies configuration of monitoring for the stack

Implements #267


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

@Hexoplon Hexoplon force-pushed the feat/helm-servicemonitor branch from 1e2c596 to c01fe34 Compare March 12, 2025 21:09
@YuhanLiu11
Copy link
Collaborator

hey @Hexoplon thanks for submitting the PR! Can you provide more instruction on how to use this new helm template?

Add support for creating a ServiceMonitor directly in the helm chart.
This simplifies configuration of monitoring for the stack

Implements vllm-project#267

Signed-off-by: Hexoplon <[email protected]>
@Hexoplon Hexoplon force-pushed the feat/helm-servicemonitor branch from c01fe34 to 74d734d Compare March 13, 2025 19:36
@Hexoplon
Copy link
Contributor Author

@YuhanLiu11 Thanks for the feedback! I updated the observability docs to enable the serviceMonitor install in the helm release values, instead of including the additionalServiceMonitor field in the kube-prom-stack values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants