Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Add mark skip for GPU #1264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kylesayrs
Copy link
Collaborator

Purpose

  • Add GPU mark skip for test_compressor_stacking, which requires a GPU
  • Add an explicit GPU test for GHA, so as to unambiguously catch situations where CUDA is not properly installed on a runner

Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs self-assigned this Mar 18, 2025
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not update/use existing tools?

def requires_gpu(test_case):

@kylesayrs
Copy link
Collaborator Author

@dsikka If you're referring to here I'm just following the convention of the file. Theoretically we could consolidate these methods at some point, esp if we want to be support amd

@kylesayrs kylesayrs requested a review from dsikka March 18, 2025 17:12
@kylesayrs kylesayrs added the ready When a PR is ready for review label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants