Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove legacy viur-queued-tasks code #1433

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

sveneberth
Copy link
Member

@sveneberth sveneberth commented Feb 26, 2025

This code was around 12 years old and would already fail on the first statement: db.Delete(currentTask.key()) (key is no longer a method...)

The counterpart does no longer exist; callableTasks are always executed direclty and decide on their own to call a DeferredTask or not.

@sveneberth sveneberth added invalid This doesn't seem right Priority: Low This issue can be considered with enough idle time. labels Feb 26, 2025
@sveneberth sveneberth changed the title chore: Remove legacy viur-queued-tasks chore: Remove legacy viur-queued-tasks code Feb 26, 2025
This code was around 12 years old and would fail on the first
statement: `db.Delete(currentTask.key())` (key is no longer a method...)

The counterpart does no longer exist; callableTasks are always executed
direclty and decide on their own to call a `DeferredTask` or not.
@phorward phorward force-pushed the chore/remove_old_code branch from 1e7903f to 8729288 Compare February 27, 2025 07:57
@phorward phorward merged commit 206d6cd into viur-framework:main Feb 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right Priority: Low This issue can be considered with enough idle time.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants