Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add check for db.Key in KeyBone.singleValueFromClient #1008

Merged
merged 6 commits into from
Jan 13, 2024
Merged

fix: Add check for db.Key in KeyBone.singleValueFromClient #1008

merged 6 commits into from
Jan 13, 2024

Conversation

ArneGudermann
Copy link
Contributor

Fix for #1007

@phorward phorward added hotfix Priority: High After critical issues are fixed, these should be dealt with before any further issues. main labels Dec 21, 2023
phorward
phorward previously approved these changes Dec 21, 2023
View reviewed changes
@phorward phorward changed the title fix: Add check for key or str in singleValueFromClient form KeyBone fix: Add check for key or str in KeyBone.singleValueFromClient Dec 22, 2023
@phorward phorward changed the title fix: Add check for key or str in KeyBone.singleValueFromClient fix: Add check for db.Key in KeyBone.singleValueFromClient Dec 22, 2023
@sveneberth sveneberth linked an issue Jan 9, 2024 that may be closed by this pull request
Assign a db.Key as value with setBoneValue to a KeyBone returns None #1007
Closed
sveneberth
sveneberth requested changes Jan 9, 2024
View reviewed changes
sveneberth
sveneberth previously approved these changes Jan 12, 2024
View reviewed changes
phorward
phorward requested changes Jan 12, 2024
View reviewed changes
@phorward phorward merged commit 96ace58 into viur-framework:main Jan 13, 2024
3 checks passed
@phorward phorward mentioned this pull request Jan 17, 2024
Open
@sveneberth sveneberth added the bug(fix) Something isn't working or address a specific issue or vulnerability label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward approved these changes

@sveneberth sveneberth sveneberth left review comments

Assignees
No one assigned
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability main Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
Documentation
Status: Todo
Milestone
ViUR-core v3.5 (LTS)
Development

Successfully merging this pull request may close these issues.

Assign a db.Key as value with setBoneValue to a KeyBone returns None
3 participants
@ArneGudermann @sveneberth @phorward