Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: show icons in code-groups and code titles, update sidebar #6970

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Nov 26, 2024

Description

I saw that Vite docs now shows icons in code titles and liked it 😄 This PR is adapted from vitejs/vite#18132

This PR also has a few cosmetic changes:

  • The sidebar now always has API and the config links
  • The config page now has the /config/file content with examples inside a spoiler. the /config/file should redirect to /config/

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 4c3c3db
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/674661a3f736e200084f6e74
😎 Deploy Preview https://deploy-preview-6970--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va changed the title docs: show icons in code-groups and code titles docs: show icons in code-groups and code titles, update sidebar Nov 26, 2024
@sheremet-va sheremet-va merged commit 38e50f1 into vitest-dev:main Nov 27, 2024
17 checks passed
@sheremet-va sheremet-va deleted the docs/icons branch November 27, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant