Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example operator.yaml to support vtgate HPA #16805

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Update example operator.yaml to support vtgate HPA #16805

merged 1 commit into from
Oct 14, 2024

Conversation

siadat
Copy link
Contributor

@siadat siadat commented Sep 18, 2024 •
edited
Loading

Description

Per planetscale/vitess-operator#598 (comment), this PR ensures examples/operator/operator.yaml is in sync with the operator, when that PR is merged.

The contents of ./test/endtoend/operator/operator-latest.yaml are copied from the vitess-operator, but the changes made to the Deployment named vitess-operator are reverted.

Related Issue(s)

planetscale/vitess-operator#598

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

This PR contains the changes needed to auto-scale vtgate deployments by the operator.

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 18, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 18, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Sep 18, 2024
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Examples Component: Operator Vtop related issues and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsWebsiteDocsUpdate What it says labels Sep 18, 2024
@siadat siadat force-pushed the update-operator.yaml-for-vtgate-hpa branch from c3c5e99 to b87b48a Compare September 18, 2024 23:26
@siadat siadat marked this pull request as draft October 2, 2024 00:41
@vitess-bot vitess-bot modified the milestones: v21.0.0, v22.0.0 Oct 8, 2024
@frouioui frouioui mentioned this pull request Oct 9, 2024
Merged
@siadat siadat force-pushed the update-operator.yaml-for-vtgate-hpa branch from b87b48a to 1a4beef Compare October 9, 2024 20:33
@siadat
Update example operator.yaml based on the latest vitess-operator's te…
cbe3015 
…st/endtoend/operator/operator-latest.yaml

Signed-off-by: Sina Siadat <[email protected]>
@siadat siadat force-pushed the update-operator.yaml-for-vtgate-hpa branch from 1a4beef to cbe3015 Compare October 9, 2024 20:36
@siadat siadat marked this pull request as ready for review October 9, 2024 20:36
siadat
siadat commented Oct 9, 2024
View reviewed changes
examples/operator/operator.yaml
@@ -2,8 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.11.3
creationTimestamp: null
controller-gen.kubebuilder.io/version: v0.16.1
Copy link
Contributor Author

@siadat siadat Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frouioui Shall I only add the HPA related changes in this PR to make the diff smaller?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to copy everything. If there is a larger diff it's because we lost sync at some point, but we should always be in sync :)

frouioui
frouioui approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mattlord
mattlord approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @siadat ! ❤️

@frouioui frouioui merged commit fc72c1c into vitessio:main Oct 14, 2024
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@mattlord mattlord mattlord approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Examples Component: Operator Vtop related issues Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@siadat @mattlord @frouioui @vitess-bot