Distributed Transaction: Action on commit prepared or redo prepared failure

[harshit-gangal]

Description

This PR make changes to transaction recovery log state in resource managers.

On a commit prepared failure it checks if the error is retryable or not.
For a non-retryable error, the state is update to FAILED, error metric is updated and then they are are not prepared later.

Same check happens on redo of prepared logs on a failure.

Once, the state is updated to Failed, a user intervention is needed to evaluate the root cause of the issue.
This is a highly unlikely scenario and could have happened due to a bug in the system.

Related Issue(s)

• RFC: Atomic Distributed Transactions #16245

Checklist

• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.51%. Comparing base (9563fcb) to head (0dbcc31).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vttablet/tabletserver/tx_engine.go	95.52%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16803      +/-   ##
==========================================
- Coverage   69.52%   69.51%   -0.01%     
==========================================
  Files        1568     1569       +1     
  Lines      202442   202555     +113     
==========================================
+ Hits       140741   140815      +74     
- Misses      61701    61740      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[systay]

After talking it over with H - maybe we could solve this by extracting the inside of the loop into a method, and using a defer in that method to check errors

[GuptaManan100]

LGTM