feat: run changed testsuites in PR ci #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sable other steps to get faster feedback
…with empty change list
|
so this doesn't work if no test file has changed, and additionally it would also run if we just changed formatting etc. which would be wasteful. An alternative could be to use a similar system as in the vite repo by triggering runs on demand from Because we don't have to deal with an external repo, the application for auth would not be needed, however we'd have to add code from vite repo that limits these comments to triage role. |
|
as mentioned in the comment above the approach in this PR isn't working in all conditions. the comment trigger should be added in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets see if this works 👀