fix: split in cli args before calling ni #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikg
reviewed
Jul 31, 2023
| @@ -146,6 +146,13 @@ export async function setupRepo(options: RepoOptions) { | |||
| } | |||
| } | |||
|
|
|||
| function splitInCliArgs(task: string) { | |||
| return task | |||
| .split(/("[^"]+"|[^\s"]+)/gim) | |||
There was a problem hiding this comment.
this can break down if you wanted to pass a literal \". Another way to support aguments for commands would be to require configs to pass an array of arrays eg
test:[['test:ci','arg-1,'arg2 with spaces'],['test:e2e','another arg']] then we can take those arrays to ni directly if the first element is a script, otherwise send it to the shell with quotes.
There was a problem hiding this comment.
Implemented this here so you can check and merge what looks better:
I'm actually fine with either approach. #234 isn't as clean as it seemed at the end though.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ni started to respect the args passed to
getCommandif they have spaces, wrapping them in quotes:I think this should do the trick for us. We could later migrate to a library to do this, for example,
--isn't respected. We don't need support for it in vite-ecosystem-ci config at this point though.