Add iterator-based version of RouteListFilter #940
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RouteListFiltered method can be quite inefficient when there are many (say 100k) routes. First all 100k routes are loaded into fragmented byte slices, appended to a slice (which must be grown through several orders of magnitude, requiring a lot of copying), then the whole
[][]byte
is kept in RAM while all the routes are parsed and returned in a second large slice.This PR adds a callback-based iterator equivalent: RouteListFilteredIter. RouteListFilteredIter loads one route from the kernel, parses it fully and passes it to the callback, then it moves to the next route. This should be a lot more efficient, especially when the caller is further converting the routes. To avoid copying too much code, RouteListFiltered is now a simple wrapper around RouteListFilteredIter, which should be more efficient due to avoiding creation of the intermediate
[][]byte
.Similarly, the main work of NetlinkRequest.Execute is moved to ExecuteIter.