chore: add internalUsageAttributionIds in the library #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Is this used as a replacement for what we're currently doing with the solution_channel parameter? |
Yes, that's the plan, right now we will use both and migrate to internalUsageAttributionIds as the sole one in the future. |
|
Converting the PR to draft for now. The update requires Google Maps JS 3.59.2, whereas the current library only requires 3.54.10. Let me check offline on the version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add internalUsageAttributionId to help Google understand which libraries and samples are helpful to developers, such as usage of this library. Instructions for opting out of the identifier are provided in README.
The value is assign as part of APIProvider context and passed to maps instance to pass to mapOptions.