Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly export UniformTypes #2339

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Explicitly export UniformTypes #2339

merged 1 commit into from
Feb 18, 2025

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Feb 18, 2025

For visgl/deck.gl#9416

Source:

export const picking = {...} as const satisfies ShaderModule<PickingProps, PickingUniforms, PickingBindings>;

Compiled (before):

export declare const pickingUniforms: {
    readonly props: PickingProps;
    readonly uniforms: PickingUniforms;
    readonly uniformTypes: Required<import("modules/shadertools/dist/lib/utils/uniform-types").UniformTypes<PickingUniforms>>;
    ...
}

Compiled (after):

export declare const pickingUniforms: {
    readonly props: PickingProps;
    readonly uniforms: PickingUniforms;
    readonly uniformTypes: Required<import("@luma.gl/shadertools").UniformTypes<PickingUniforms>>;
    ...
}

Change List

  • Explicitly export UniformTypes from @luma.gl/shadertools

@Pessimistress Pessimistress merged commit 75df411 into master Feb 18, 2025
2 checks passed
@Pessimistress Pessimistress deleted the x/type-fix branch February 18, 2025 19:03
Pessimistress added a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants