Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing dependencies #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

merceyz
Copy link

@merceyz merceyz commented Oct 16, 2020

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

jest-vue-preprocessor is trying to use @babel/template, @babel/core, and pug without declaring them as dependencies. This causes it to rely on the user to install them and hoisting to make them available which is not guaranteed

What is the new behavior?

  • @babel/template and @babel/core have been moved from devDependencies to dependencies
  • pug has been added as an optional peer dependency

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant