Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update pinia to v3 #204

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

4350pChris
Copy link
Member

Updates pinia to v3, also updates vue to match pinia's peer deps.

@brillout
Copy link
Member

Seems like no vike-vue-pinia changes are required? Thus, how about we keep "pinia": ">=2.0.0"? I guess we don't need to release a new version.

@4350pChris
Copy link
Member Author

Yes I meant to ask you about that. Pinia 3 drops support for Vue 2, reducing size. Since we're not supporting Vue 2 anyways, I thought this might entice users to update.
Wdyt?

@brillout
Copy link
Member

Pinia v3 is a boring major release with no new features. It drops deprecated APIs and updates major dependencies. It only supports Vue 3

I see.

In principle I agree, but I'd still keep "pinia": ">=2.0.0" to be safe and to signal that Vike doesn't want to be prescriptive. But as you wish, no strong opinion here.

Feel free to decide, merge, and release. If you go for "pinia": ">=3.0.0" then make sure to add fix: to the squash-merge commit, include a BREAKING CHANGE: , and bump the major.

Btw. I'm planning to write docs for vike-vue-{pinia,query} next week. Contribution welcome in case you're up for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants