Backport 4.5.8 to scala 2.12 #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- merge form 5c3006f - make scala version configurable through properties in `pom.xml`s - Remove generated sources
- Merge 234addd adding itests - `tupleOf` helper function to use instead of `Tuple.of` that gives `ambiguous reference to overloaded definition` error - `execute` extension method with varargs not requiring Tuple for `PreparedQuery.execute`
- Add scalacOption: -Xsource:3
|
Hi there and thanks for the PR! ♥ We moved to Scala 3 because we wanted to keep it simple and maintain only one Scala code generator. Plus, Scala 3 has some nice features which we may use eventually and which could be hard to backport. Feel free to fork this repo if you would like to maintain a Scala 2 branch of vertx-lang-scala. |
|
Do you create a branch for it in this repo or I should publish it with a different org id? |
Not sure what you mean with org id. You can create a fork under your own account. In that case, I would set a different Maven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why scala 2 was abadoned, but I made a backport.
I can maintain if you like. In a separate branch?
pom.xmls