Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency change to smoothen deployment #1027

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Priyansh4444
Copy link

#1023
Multiple users include my friend were facing an issue regarding deployment with bcrypt,
I think since this is a tutorial and only for learning purposes using bcryptjs for now is fine, since it is stable and does not cause an error.

Copy link

vercel bot commented Mar 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-learn-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2025 8:23am
next-seo-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2025 8:23am

Copy link

vercel bot commented Mar 15, 2025

@Priyansh4444 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 112 kB dcode

View full report↗︎

@w0244079
Copy link

w0244079 commented Mar 19, 2025

I and other individuals have tried this approach and it does build on vercel but the resulting site's login process fails with a 404 error. Fixing the core issue (building the required packages....bcrypt and sharp) is the better solution than switching to bcryptjs.

There should really be a step in the tutorial that prompts the user to run the approve-builds pnpm command as suggested.

@Priyansh4444 Did you test the login on vercel after deployment to confirm that it works?

PR #1016 already addresses this fix.

@Priyansh4444
Copy link
Author

Admittedly, I only tested this via localhost on my friends laptop that worked and glad the issue was resolved, this pr can be closed but do agree with confirmation before deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants