Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the output of the slack stats to show milestone coverage #130

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

gordsport
Copy link
Contributor

This updates the Jenkins output for slack to show both overall AC coverage stats and the current milestone stats.

The intended output is like this:

All ACs:
Criteria: 2386 Covered: 1790 by/FeatTest: 565 by/SysTest: 1160 Uncovered: 596 Coverage: 75.0%
Current milestone ACs:
Criteria: 100 Covered: 99 by/FeatTest: 98 by/SysTest: 1 Uncovered: 1 Coverage: 99.0%

This updates the Jenkins output for slack to show both overall AC coverage stats and the current milestone stats.

The intended output is like this:

All ACs:
Criteria: 2386  Covered: 1790  by/FeatTest: 565  by/SysTest: 1160  Uncovered: 596  Coverage: 75.0%
Current milestone ACs:
Criteria: 100  Covered: 99  by/FeatTest: 98  by/SysTest: 1  Uncovered: 1  Coverage: 99.0%
@gordsport gordsport requested a review from edd January 12, 2024 11:23
@gordsport gordsport self-assigned this Jan 12, 2024
@gordsport gordsport changed the title chore: update the output of the slack stats to show milestone coverage too chore: update the output of the slack stats to show milestone coverage Jan 12, 2024
gordsport added a commit to vegaprotocol/jenkins-shared-library that referenced this pull request Jan 12, 2024
Updates the version of approbation on to 4.6.2 to get the updates from:

- vegaprotocol/approbation#130
Copy link
Contributor

@edd edd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how Slack is going to render this output, but let's find out

@edd edd merged commit d605e58 into main Jan 12, 2024
2 checks passed
@edd edd deleted the update-approbation-slack-output branch January 12, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants