Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esefah meng history strip #535

Open
wants to merge 6 commits into
base: esefah-meng
Choose a base branch
from
Open

Conversation

NanaKwame
Copy link
Contributor

@NanaKwame NanaKwame commented Mar 30, 2021

This PR includes:

  • changes for showing the history at the bottom of the page
  • DnD of the history items.
  • Being able to drag history items to x, y, fill or size on the bubble cursor and see scale updates
  • Being able to drag history items to the main chart but not on the bubble cursor to see aesthetic updates to marks: "size", "shape", "fill", "fillOpacity", "stroke", "strokeWidth"

TODOs amongst bigger todos:

  • fix any issues that might come up with changes to exporter.ts and cleanSpecForPreview in demonstrations.ts
  • figure out if I need to use History.ts
  • other mark types aren't working perfectly. currently symbols work the best

@lgtm-com
Copy link

lgtm-com bot commented Mar 30, 2021

This pull request introduces 4 alerts when merging fdf2c63 into f805c6d - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

src/js/ctrl/export.ts Outdated Show resolved Hide resolved
src/js/ctrl/export.ts Outdated Show resolved Hide resolved
src/js/ctrl/export.ts Outdated Show resolved Hide resolved
Copy link
Member

@jonathanzong jonathanzong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! i've left comments that i hope are helpful. since it's a working branch, i'll leave it up to you what level of detail you want to address them to before merging

@NanaKwame
Copy link
Contributor Author

nice work! i've left comments that i hope are helpful. since it's a working branch, i'll leave it up to you what level of detail you want to address them to before merging

I have pushed changes to address your comments. Please send any feedback especially for cleanHistorySpec in HistortyList.tsx. Not sure if that is the right/ok way to go about removing interactions from the history previews.

@lgtm-com
Copy link

lgtm-com bot commented Apr 4, 2021

This pull request introduces 11 alerts when merging 82b2fa4 into f805c6d - view on LGTM.com

new alerts:

  • 11 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 4, 2021

This pull request introduces 11 alerts when merging ba9b9fc into f805c6d - view on LGTM.com

new alerts:

  • 11 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 4, 2021

This pull request introduces 1 alert and fixes 1 when merging 8515e2e into f805c6d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

const scaleInfo = getScaleInfoForGroup(state, group._id);
const fieldsOfGroup = getFieldsOfGroup(state, group._id);
const scaleInfo = getScaleInfoForGroup(storeState, group._id);
const fieldsOfGroup = getFieldsOfGroup(storeState, group._id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that i think about it, these should use visState too. if we pass in an older visState to the exporter, we expect it to get the scale info for that state. using the store state will use the current scale info instead, which could cause problems.

this means that the getScaleInfoForGroup and getFieldsOfGroup functions should probably be edited to use visState as well, and all uses of those functions updated accordingly. could you add one more commit with that change?

@jonathanzong
Copy link
Member

great work implementing the earlier feedback! your approach in cleanHistorySpec looks right to me. left one comment for one last refactoring task then you're good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants