mypy w/ reviewdog (experiment) #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 078ebb7.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -262,15 +262,15 @@ def progress_cb(output, timestamp): | |||
| umask=umask, | |||
| ) | |||
|
|
|||
| all_output: list[str] = [] | |||
| all_output = [] | |||
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Need type annotation for "all_output" (hint: "all_output: List[] = ...")
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 70.35% 70.35%
=======================================
Files 21 21
Lines 1882 1882
=======================================
Hits 1324 1324
Misses 558 558 Continue to review full report at Codecov.
|
tony
force-pushed
the
master
branch
3 times, most recently
from
5354b23 to
effff43
Compare
tony
force-pushed
the
master
branch
4 times, most recently
from
cf9f3ef to
410e041
Compare
tony
force-pushed
the
master
branch
2 times, most recently
from
7f69eab to
c480bb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tsuyoshicho/action-mypy w/ https://github.com/reviewdog/reviewdog