Replace deterministic random values with actual randomness in tests #3000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests used identical fixed random instances inside a loop, causing the extact same sequence of numbers being generated:
Each iteration will generate a fixed sequence (in this case:
2554, 3297, 4789, ...
)Unless I am missing the purpose, this means that each loop is identical and thus redundant.
Generating the same sequence of numbers via a Random does not seem to be the intented design here.
If my assumptions are correct, this fixes both issues by using an unseeded random instance, creating a test run with actual randomness.
If each loop iteration should be different but deterministic values are desired, a different fix could be to move the random instance out of the loop: