Skip to content

Add support for threaded use of Try.withResources() for up to 3 arguments #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: version/1.x
Choose a base branch
from

Conversation

thinstripe
Copy link

@thinstripe thinstripe commented Nov 24, 2023

It would be useful to be able to thread your Autocloseable resources when using Try.withResources() in common scenarios/use cases such as database related resource management (Connection, PreparedStatement, ResultSet).

For example :-

Try.withResources(dataSource::getConnection, conn -> conn.prepareStatement("SELECT id, name from books"), PreparedStatement::executeQuery).of(rs -> /* extract what you need from ResultSet */)

Is equivalent but preferable to :-

Try.of(() -> try(Connection conn = dataSource.getConnection(); PreparedStatement stmt = conn.prepareStatement("SELECT id, name from books"); ResultSet rs = stmt.executeQuery())).flatMap(rs -> /* extract what you need from ResultSet */);

…ents.

3 arguments is probably enough to cover common scenarios/use cases such as database related resource management (Connection, PreparedStatement, ResultSet).
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (version/1.x@58698b7). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             version/1.x    #2752   +/-   ##
==============================================
  Coverage               ?   92.85%           
  Complexity             ?     5273           
==============================================
  Files                  ?       89           
  Lines                  ?    12574           
  Branches               ?     1598           
==============================================
  Hits                   ?    11675           
  Misses                 ?      711           
  Partials               ?      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant