Updated the repo to work with the application load balancer. #17
Conversation
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 17.07% 17.22% +0.15%
==========================================
Files 3 4 +1
Lines 205 296 +91
==========================================
+ Hits 35 51 +16
- Misses 170 245 +75
Continue to review full report at Codecov.
|
|
Bummer this hasn't been merged into a 0.7.0 yet... We're just going to pull skelpo's vapor-aws-lambda-runtime instead... |
| @@ -11,7 +11,7 @@ build_lambda: | |||
| $(SWIFT_DOCKER_IMAGE) \ | |||
| swift build --product Hello -c release | |||
|
|
|||
| package_lambda: build_lambda | |||
There was a problem hiding this comment.
Any particular reason this was removed?
| @@ -0,0 +1,90 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
These files should be removed - I think if you rebase the current main on to yours it should pull in an updated gitignore with .swiftpm - if not could you add it and remove these?
| @@ -16,7 +16,7 @@ let package = Package( | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/apple/swift-nio.git", .upToNextMajor(from: "2.13.0")), | |||
| .package(url: "https://github.com/swift-server/swift-aws-lambda-runtime.git", .upToNextMajor(from: "0.3.0")), | |||
| nioHeaders.add(name: key, value: value) | ||
| } | ||
|
|
||
| /*if let cookies = req., cookies.count > 0 { |
| } | ||
| } | ||
|
|
||
| ctx.logger.debug("The constructed URL is: \(url)") |
There was a problem hiding this comment.
I'd prefer this be at trace level since it's coming from the library - See the log level PR for what we're trying to move towards
| @@ -79,13 +79,13 @@ public class LambdaServer: Server { | |||
| public enum RequestSource { | |||
| case apiGateway | |||
| case apiGatewayV2 | |||
| // case applicationLoadBalancer // not in this release | |||
| case applicationLoadBalancer | |||
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
This includes everything needed to run Vapor apps through Lambda. I've left it as it is working for me now and it's open for discussion.
Some things, like config and the exact branches (pending merging of the swift-lambda-runtime) need to be adjusted but this way people can comment, suggest and improve things already. :)