Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies for nuxt, vue and vant packages #23

Merged
merged 5 commits into from
Sep 2, 2023

Conversation

retrogradeMT
Copy link
Contributor

This pulls in the latest version of Vue (3.3.4), Vant (4.6.6), nuxt (3.7.0), @nuxt/schema(3.7.0), @nuxt/kit(3.7.0), @nuxt/module-builder(0.5.0), typescript(5.1.6), and eslint(48.46.0).

The playground/app.vue file was updated to include a FloatingPanel component

The module.ts was modified to clear a typescript error by adding a type assertion for sourcemap.

Motivation for the PR: There have been some bug fixes in Vant between the current version used in this module (4.2.0) and the latest version (4.6.6).

package.json Outdated Show resolved Hide resolved
playground/app.vue Outdated Show resolved Hide resolved
src/module.ts Outdated Show resolved Hide resolved
@retrogradeMT
Copy link
Contributor Author

I looked into adjusting the pluginOptions but it looked complete, I added in a type guard to module.ts as alternative approach.

src/module.ts Outdated Show resolved Hide resolved
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your contribution

@tolking tolking merged commit fa69d3c into vant-ui:main Sep 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants