-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update all tooling #2401
base: master
Are you sure you want to change the base?
fix: update all tooling #2401
Conversation
I think this fixes things @profnandaa . We can do a beta release for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a breaking change since we drop support for Node <18. So we'll need to keep that in mind when merging
just a quick observation: the biggest chunk of changes here seem to be style changes -> is there a reason for that? |
I could reroll the style changes but those are from eslint fix. |
Not 100% sure, but default configuration can change over minor versions and it might be due to a case that wasn't discovered in earlier versions but is now. If we want to not have those changes we can update the configuration manually |
Updates all tools (expect mocha and nyc)
Also has the files linted (was not linted before thus many file changes )
Checklist